Make Unix sockets writable for user group #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djmattyg007
requested changes
Aug 14, 2022
|
The try/finally clause that was requested has been added. I don't see the need for a feature flag to enable this behavior, I believe making sockets group-writable is a sane default. |
While I agree with you, this code removes the ability of users to control the umask themselves for this socket, so it's worth thinking about. |
Modified the call signature Server.create_server_socket to accept socket_permissions as an optional parameter. get_socket_umask will return the default umask of `0o002` when called with no explicit permissions.
|
Apologies for the lack of updates for a while. I just implemented the config option |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Mopidy is run as a system service under the
mopidyuser, Unix sockets are currently created with a umask of022, which makes other users unable to connect due to having no write permission. This PR ensures Unix sockets are created with a umask of002, making them writable to users in themopidygroup and thus usable to users added to this group.